linux-kernel - Re: [PATCH][SQUASHME] osdblk is dependent on SCSI_OSD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4A3917CC.1060105@oracle.com>
Date:	Wed, 17 Jun 2009 09:20:28 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Boaz Harrosh <bharrosh@...asas.com>
CC:	Stephen Rothwell <sfr@...b.auug.org.au>,
	Jeff Garzik <jeff@...zik.org>, linux-next@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	scsi <linux-scsi@...r.kernel.org>,
	open-osd mailing-list <osd-dev@...n-osd.org>
Subject: Re: [PATCH][SQUASHME] osdblk is dependent on SCSI_OSD_ULD

Boaz Harrosh wrote:
> I will be squashing the below patch into the osdblk patch and will
> rebase the "linux-next" branch. (No one is dependent on this branch
> so there is no reason not too)
> 
> ---
> Stephen Rothwell wrote:
> When
> CONFIG_BLK_DEV_OSD=y
> CONFIG_SCSI_OSD_INITIATOR=y
> \# CONFIG_SCSI_OSD_ULD is not set
> 
> build fails with:
> drivers/built-in.o: In function `class_osdblk_remove':
> osdblk.c:(.text+0x55376): undefined reference to `osduld_put_device'
> drivers/built-in.o: In function `class_osdblk_add':
> osdblk.c:(.text+0x5564d): undefined reference to `osduld_path_lookup'
> osdblk.c:(.text+0x5584d): undefined reference to `osduld_put_device'
> 
> Fix by setting the proper dependency for this driver
> 
> Signed-off-by: Boaz Harrosh <bharrosh@...asas.com>

Acked-by: Randy Dunlap <randy.dunlap@...cle.com>

Thanks.

> ---
>  drivers/block/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
> index 2f55a4b..1d886e0 100644
> --- a/drivers/block/Kconfig
> +++ b/drivers/block/Kconfig
> @@ -300,7 +300,7 @@ config BLK_DEV_NBD
>  
>  config BLK_DEV_OSD
>  	tristate "OSD object-as-blkdev support"
> -	depends on SCSI_OSD_INITIATOR
> +	depends on SCSI_OSD_ULD
>  	---help---
>  	  Saying Y or M here will allow the exporting of a single SCSI
>  	  OSD (object-based storage) object as a Linux block device.


-- 
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/