[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090618072758.GI22013@balbir.in.ibm.com>
Date: Thu, 18 Jun 2009 12:57:58 +0530
From: Balbir Singh <balbir@...ux.vnet.ibm.com>
To: Ingo Molnar <mingo@...e.hu>
Cc: Frans Pop <elendil@...net.nl>,
Subrata Modak <subrata@...ux.vnet.ibm.com>,
"Figo.zhang" <figo1802@...il.com>,
lkml <linux-kernel@...r.kernel.org>,
Sumit Panchasara <sumit.panchasara@...fochips.com>,
"'Sachin P Sant'" <sachinp@...ux.vnet.ibm.com>,
"'H. Peter Anvin'" <hpa@...or.com>,
"'Andi Kleen'" <andi@...stfloor.org>,
"'Thomas Gleixner'" <tglx@...utronix.de>,
Jaswinder Singh Rajput <jaswinder@...nel.org>
Subject: Re: [PATCH]x86-tsc.c : fix compile warning
* Ingo Molnar <mingo@...e.hu> [2009-06-17 18:23:03]:
>
> * Frans Pop <elendil@...net.nl> wrote:
>
> > On Wednesday 17 June 2009, Ingo Molnar wrote:
> > > Ah, and you fixed in what a superior way: you improved the code in
> > > the process :-) This is how warnings should be fixed really.
> >
> > Hmm. Did you also see Pavel's reply to that patch [1]:
> > ! But that's a bug to be fixed, I'd say? ... actually I believe you are
> > ! introducing a bug here. Yes, old code would put random numbers in
> > ! loops_per_jiffy_ref for !CPUFREQ_CONST_LOOPS, but you are introducing
> > ! oops there.
> >
> > Was his comment incorrect?
> >
> > Cheers,
> > FJP
> >
> > [1] http://lkml.org/lkml/2009/5/24/159
>
> hm, Pavel seems right - i missed that. Subrata, mind sending an
> updated patch?
>
Hi, Ingo,
Yes, it does seem that we'll oops at *lpj, but to be honest the code
is badly written, ideally the CONFIG_SMP part should be abstracted
out, having that in a if loop makes reading it time consuming and
kills a few neuro cells each time.
--
Balbir
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists