linux-kernel - Re: staging driver s626 clashes with philips SAA7146 media/dvb based cards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200906180328.07976.fmhess@speakeasy.net>
Date:	Thu, 18 Jun 2009 03:28:04 -0400
From:	Frank Mori Hess <fmhess@...akeasy.net>
To:	Herton Ronaldo Krzesinski <herton@...driva.com.br>
Cc:	fmhess@...rs.sourceforge.net, Ian Abbott <abbotti@....co.uk>,
	Greg KH <gregkh@...e.de>, LKML <linux-kernel@...r.kernel.org>,
	Gianluca Palli <gpalli@...s.unibo.it>,
	David Schleef <ds@...leef.org>
Subject: Re: staging driver s626 clashes with philips SAA7146 media/dvb based cards

On Wednesday 17 June 2009, Herton Ronaldo Krzesinski wrote:
> >
> > Your patch breaks configuration of the board unless the bus and slot
> > are explicitly specified.  Just make a minimal patch that replaces
> > pci_get_device with pci_get_subsys and fixes the problem that was
> > reported.
>
> Hmm that's not what the patch does, it doesn't break configuration,
> keeps the same logic as before (I was wrong in my last email replying to
> myself), check it, if it->options[0] and it->options[1] isn't specified,
> the pdev is valid so the for loop exits (see !pdev check).

Your right.  However, it also turns a loop over pci devices into a loop 
over pci ids, which appears to break the case of multiple s626 boards 
where the bus/slot of the second s626 board is specified.  If you're not 
willing to provide a minimal patch that just fixes the reported problem, 
just say so.  It would have been less effort for me to do it myself than 
analyze what your changes are breaking.


Download attachment "signature.asc " of type "application/pgp-signature" (190 bytes)