linux-kernel - Re: [PATCH 1/3] usb,console: Fix regression in usb console on kernel boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090618101130.2bc3cae8@lxorguk.ukuu.org.uk>
Date:	Thu, 18 Jun 2009 10:11:30 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Jason Wessel <jason.wessel@...driver.com>
Cc:	greg@...ah.com, linux-kernel@...r.kernel.org,
	Jason Wessel <jason.wessel@...driver.com>
Subject: Re: [PATCH 1/3] usb,console: Fix regression in usb console on
 kernel boot

On Wed, 17 Jun 2009 21:20:07 -0500
Jason Wessel <jason.wessel@...driver.com> wrote:

> The commit 335f8514f200e63d689113d29cb7253a5c282967 introduced a
> regression which stopped usb consoles from working correctly as a
> kernel boot console as well as interactive login device.
> 
> The addition of the serial_close() which in turn calls
> tty_port_close_start() will change the reference count of port.count
> and warn about it.  The usb console code had previously incremented
> the port.count to indicate it was making use of the device as a
> console and the forced change causes a double open on the usb device
> which leads to a non obvious kernel oops later on when the tty is
> freed.
> 
> To fix the problem instead make use of port->console to track if the
> port is in fact an active console port to avoid double initialization
> of the usb serial device.  The port.count is incremented and
> decremented only with in the scope of usb_console_setup() for the
> purpose of the low level driver initialization.

Acked-by: Alan Cox <alan@...ux.intel.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/