linux-kernel - Re: [PATCH 2/3] usb-serial: regression fix to move sysrq from hot path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090618101320.15c036a6@lxorguk.ukuu.org.uk>
Date:	Thu, 18 Jun 2009 10:13:20 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Jason Wessel <jason.wessel@...driver.com>
Cc:	greg@...ah.com, linux-kernel@...r.kernel.org,
	Jason Wessel <jason.wessel@...driver.com>
Subject: Re: [PATCH 2/3] usb-serial: regression fix to move sysrq from hot
 path

> +	if (port->console) {

	unlikely(port->console) I think is justified

> +		for (i = 0; i < urb->actual_length; i++, ch++) {
> +			if (!usb_serial_handle_sysrq_char(port, *ch))
> +				tty_insert_flip_char(tty, *ch, TTY_NORMAL);

But thats a minor twiddle so

Acked-by: Alan Cox <alan@...ux.intel.com>

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/