linux-kernel - Re: [PATCH 12/16] x86, mce: squash mce_intel.c into therm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A3A4790.3090407@zytor.com>
Date:	Thu, 18 Jun 2009 06:56:32 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	huang ying <huang.ying.caritas@...il.com>
CC:	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 12/16] x86, mce: squash mce_intel.c into therm_throt.c

huang ying wrote:
> 2009/6/15 Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>:
>> move intel_init_thermal() into therm_throt.c
>>
>> Signed-off-by: Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
>> ---
>>  arch/x86/kernel/cpu/mcheck/Makefile      |    2 +-
>>  arch/x86/kernel/cpu/mcheck/mce_intel.c   |   73 ------------------------------
>>  arch/x86/kernel/cpu/mcheck/therm_throt.c |   66 +++++++++++++++++++++++++++
>>  3 files changed, 67 insertions(+), 74 deletions(-)
>>  delete mode 100644 arch/x86/kernel/cpu/mcheck/mce_intel.c
> 
> Why we need this patch? I think the design principle behind MCE is to
> separate vendor/cpu specific code into different files. At least
> #ifdef CONFIG_X86_MCE_INTEL should be used around moved code.
> 

Honestly, such a design principle is pretty broken.  mce_intel.c
contained two completely orthogonal piece of functionality -- CMCI and
thermal -- that really should be in different files (and mce_intel.c
probably should be renamed cmci.c).  Furthermore, using #ifdef for
selecting specific code is considered less clean than using the Makefile
for this purpose.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/