linux-kernel - Re: [PATCH 01/17] arm: arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090619091323.GA18246@flint.arm.linux.org.uk>
Date:	Fri, 19 Jun 2009 10:13:23 +0100
From:	Russell King <rmk+lkml@....linux.org.uk>
To:	Roland McGrath <roland@...hat.com>
Cc:	Christoph Hellwig <hch@....de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/17] arm: arch_ptrace clean-up

On Fri, Apr 24, 2009 at 05:07:32PM -0700, Roland McGrath wrote:
> This cleans up arch_ptrace() on arm to use the generic ptrace_request()
> for everything it can.  This gets rid of the non-arch ptrace internals
> magic from the arch code.

It also changes the semantics a bit, and I don't buy the "it doesn't
matter" comments, especially in the PT_SINGLESTEP case.  Having
PT_SINGLESTEP set the flag but later fail is not nice behaviour at all,
it means that, despite the ptrace call failing, the next time that the
task encounters a signal, it will enter single stepping mode.

Therefore, I believe this patch is wrong.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/