linux-kernel - blk-settings.c integer truncation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20090619092002.GB3222@localdomain.by>
Date:	Fri, 19 Jun 2009 12:20:02 +0300
From:	Sergey Senozhatsky <sergey.senozhatsky@...l.by>
To:	Jens Axboe <jens.axboe@...cle.com>
Cc:	"Martin K. Petersen" <martin.petersen@...cle.com>,
	linux-kernel@...r.kernel.org
Subject: blk-settings.c integer truncation

Hello.
I was asking
> Should BLK_BOUNCE_ANY be (-1UL)?

No. It should not.

git annotate gives for blkdev.h:
Andi Kleen     2008-04-21 09:51:05 +0200       705)#define BLK_BOUNCE_ANY              (-1ULL)
...

...
(Martin K. Petersen     2009-05-22 17:17:51 -0400       311)    unsigned long           bounce_pfn;
...
(Martin K. Petersen     2009-05-22 17:17:50 -0400       1020)static inline unsigned long queue_bounce_pfn(struct request_queue *q)
(Martin K. Petersen     2009-05-22 17:17:50 -0400       1021){
(Martin K. Petersen     2009-05-22 17:17:51 -0400       1022)   return q->limits.bounce_pfn;
(Martin K. Petersen     2009-05-22 17:17:50 -0400       1023)}
...

I think, commit need to be reworked a bit.

	Sergey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/