linux-kernel - Re: [PATCH 2/2 v2] Blackfin: fix dma-mapping build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200906231040.46767.arnd@arndb.de>
Date:	Tue, 23 Jun 2009 10:40:46 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Mike Frysinger <vapier@...too.org>
Cc:	linux-kernel@...r.kernel.org,
	uclinux-dist-devel@...ckfin.uclinux.org,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
Subject: Re: [PATCH 2/2 v2] Blackfin: fix dma-mapping build errors

On Tuesday 23 June 2009, Mike Frysinger wrote:

> +static inline void dma_sync_sg_for_device(struct device *dev,
> +					struct scatterlist *sg,
> +					int nents, enum dma_data_direction dir)
> +{
> +}

If you flush the dcache in dma_map_sg, you probably also need to
flush it in dma_sync_*_for_device:

static inline void
dma_sync_sg_for_device(struct device *dev, struct scatterlist *sglist,
                      int nents, enum dma_data_direction direction)
{
       struct scatterlist *sg;
       int i;

       for_each_sg(sglist, sg, nents, i)
               invalidate_dcache_range(sg_virt(sg), sg_virt(sg) + sg->length);
}

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/