linux-kernel - Re: [PATCH 2/2] Blackfin: fix dma-mapping build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090623113616B.fujita.tomonori@lab.ntt.co.jp>
Date:	Tue, 23 Jun 2009 11:37:48 +0900
From:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
To:	vapier.adi@...il.com
Cc:	fujita.tomonori@....ntt.co.jp, linux-kernel@...r.kernel.org,
	uclinux-dist-devel@...ckfin.uclinux.org
Subject: Re: [PATCH 2/2] Blackfin: fix dma-mapping build errors

On Mon, 22 Jun 2009 22:29:29 -0400
Mike Frysinger <vapier.adi@...il.com> wrote:

> On Mon, Jun 22, 2009 at 22:14, FUJITA Tomonori wrote:
> > On Mon, 22 Jun 2009 21:54:46 -0400 Mike Frysinger wrote:
> >> The recent deprecation of dma_sync_{sg,single} ironically broke Blackfin
> >> systems.
> >
> > Oops, sorry about that.
> >
> >> This is because we don't define dma_sync_sg_for_cpu at all, so
> >> until the DMA asm-generic conversion/cleanup is done after the next
> >> release, simply redirect the dma_sync_sg_for_cpu to the debug version.
> >
> > This doesn't look correct (though it works). dma-debug.h is supposed
> > to be used by architectures that support DMA_API_DEBUG feature
> > (blackfin doesn't support it). dma_sync_sg_for_cpu is not the
> > debug version of dma_sync_sg_for_cpu.
> 
> guessing you meant "debug_dma_sync_sg_for_cpu is not the debug version
> of dma_sync_sg_for_cpu"

Sorry, yeah, your guess is correct.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/