linux-kernel - Re: [tip:sched/urgent] sched: Hide runqueues from direct refer at source code level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090623.132920.886429909279624487.mitake@dcl.info.waseda.ac.jp>
Date:	Tue, 23 Jun 2009 13:29:20 +0900 (JST)
From:	Hitoshi Mitake <mitake@....info.waseda.ac.jp>
To:	mingo@...e.hu
Cc:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	tglx@...utronix.de, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:sched/urgent] sched: Hide runqueues from direct refer at
 source code level

From: Ingo Molnar <mingo@...e.hu>
Subject: Re: [tip:sched/urgent] sched: Hide runqueues from direct refer at source code level
Date: Mon, 22 Jun 2009 17:35:22 +0200

> > 
> > Thanks for your fix, I didn't notice...
> > I wrote a patch to fix these two points.
> > 
> > After applying this patch,
> > all direct reference to runqueues is in macros. How is this?
> > 
> > Signed-off-by: Hitoshi Mitake <mitake@....info.waseda.ac.jp>
> > 
> > diff --git a/kernel/sched.c b/kernel/sched.c
> > index 8ec9d13..e2ca8c1 100644
> > --- a/kernel/sched.c
> > +++ b/kernel/sched.c
> > @@ -692,6 +692,7 @@ static inline int cpu_of(struct rq *rq)
> >  #define this_rq()		(&__get_cpu_var(runqueues))
> >  #define task_rq(p)		cpu_rq(task_cpu(p))
> >  #define cpu_curr(cpu)		(cpu_rq(cpu)->curr)
> > +#define raw_rq()		(&__raw_get_cpu_var(runqueues))
> >  
> >  inline void update_rq_clock(struct rq *rq)
> >  {
> > @@ -6625,7 +6626,7 @@ EXPORT_SYMBOL(yield);
> >   */
> >  void __sched io_schedule(void)
> >  {
> > -	struct rq *rq = &__raw_get_cpu_var(runqueues);
> > +	struct rq *rq = raw_rq();
> >  
> >  	delayacct_blkio_start();
> >  	atomic_inc(&rq->nr_iowait);
> > @@ -6637,7 +6638,7 @@ EXPORT_SYMBOL(io_schedule);
> >  
> >  long __sched io_schedule_timeout(long timeout)
> >  {
> > -	struct rq *rq = &__raw_get_cpu_var(runqueues);
> > +	struct rq *rq = raw_rq();
> >  	long ret;
> >  
> >  	delayacct_blkio_start();
> 
> Looks good - mind submitting a separate patch with a changelog, etc?
> 
> 	Ingo
> 

No, I have no fix to post now. Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/