| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20090623043058.GA3249@linux.vnet.ibm.com>
Date: Tue, 23 Jun 2009 10:00:58 +0530
From: Arun R Bharadwaj <arun@...ux.vnet.ibm.com>
To: mingo@...e.hu
Cc: linux-kernel@...r.kernel.org,
poornima nayak <mpnayak@...ux.vnet.ibm.com>,
Arun Bharadwaj <arun@...ux.vnet.ibm.com>
Subject: Re: [BUG] timer_migration interface accepts any number as input in
2.6.30-git9
* poornima nayak <mpnayak@...ux.vnet.ibm.com> [2009-06-22 16:52:08]:
> Hi Arun,
>
> Patch given by you fixes the reported bug.
>
> Regds
> Poornima
Hi Ingo,
Can you please include this minor interface bug fix for timer
migration?
thanks,
Signed-off-by: Arun R Bharadwaj <arun@...ux.vnet.ibm.com>
Reported-by: Poornima Nayak <mpnayak@...ux.vnet.ibm.com>
Tested-by: Poornima Nayak <mpnayak@...ux.vnet.ibm.com>
---
kernel/sysctl.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
Index: linux.trees.git/kernel/sysctl.c
===================================================================
--- linux.trees.git.orig/kernel/sysctl.c
+++ linux.trees.git/kernel/sysctl.c
@@ -335,7 +335,10 @@ static struct ctl_table kern_table[] = {
.data = &sysctl_timer_migration,
.maxlen = sizeof(unsigned int),
.mode = 0644,
- .proc_handler = &proc_dointvec,
+ .proc_handler = &proc_dointvec_minmax,
+ .strategy = &sysctl_intvec,
+ .extra1 = &zero,
+ .extra2 = &one,
},
#endif
{
> On Wed, 2009-06-17 at 15:51 +0530, Arun R Bharadwaj wrote:
> > * poornima nayak <mpnayak@...ux.vnet.ibm.com> [2009-06-17 14:42:16]:
> >
> > > Hi
> > >
> > > Timer migration interface /proc/sys/kernel/timer_migration in
> > > 2.6.30-git9 accepts any numerical value as input.
> > > Steps to reproduce
> > > 1. echo -6666666 > /proc/sys/kernel/timer_migration
> > > 2. cat /proc/sys/kernel/timer_migration
> > > -6666666
> > >
> > > 1. echo 44444444444444444444444444444444444444444444444444444444444 > /proc/sys/kernel/timer_migration
> > > 2. cat /proc/sys/kernel/timer_migration
> > > -1357789412
> > >
> > > Expected behavior: Should 'echo: write error: Invalid argument' while
> > > setting any value other then 0 & 1
> > >
> > > Regards
> > > Poornima
> > >
> >
> > Hi Poornima,
> >
> > Thanks for reporting the bug.
> > Hope this patch removes the bug.
> > The patch is based against the latest -tip/master.
> >
> > --arun
> >
> >
> > Signed-off-by: Arun R Bharadwaj <arun@...ux.vnet.ibm.com>
> > ---
> > kernel/sysctl.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > Index: linux.trees.git/kernel/sysctl.c
> > ===================================================================
> > --- linux.trees.git.orig/kernel/sysctl.c
> > +++ linux.trees.git/kernel/sysctl.c
> > @@ -335,7 +335,10 @@ static struct ctl_table kern_table[] = {
> > .data = &sysctl_timer_migration,
> > .maxlen = sizeof(unsigned int),
> > .mode = 0644,
> > - .proc_handler = &proc_dointvec,
> > + .proc_handler = &proc_dointvec_minmax,
> > + .strategy = &sysctl_intvec,
> > + .extra1 = &zero,
> > + .extra2 = &one,
> > },
> > #endif
> > {
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists