linux-kernel - Re: Regression with commit f9cde5f in 2.6.30-gitX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090624122209.GC20564@elte.hu>
Date:	Wed, 24 Jun 2009 14:22:09 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Len Brown <lenb@...nel.org>
Cc:	Larry Finger <Larry.Finger@...inger.net>,
	Gary Hade <garyhade@...ibm.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	LKML <linux-kernel@...r.kernel.org>,
	x86 maintainers <x86@...nel.org>, Len Brown <lenb@...nel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: Regression with commit f9cde5f in 2.6.30-gitX


* Jaswinder Singh Rajput <jaswinder@...nel.org> wrote:

> On Tue, 2009-06-23 at 20:33 -0500, Larry Finger wrote:
> > My latest pull from Linus's tree fails to boot. Bisection leads to the
> > commit entitled "x86/ACPI: Correct maximum allowed _CRS returned
> > resources and warn if exceeded" with hash
> > f9cde5ffed17bf74f6bef042d99edb0622f58576. I have been unable to
> > capture the first error message as it scrolls off the screen, but the
> > second hits the WARN_ON at drivers/ata/ahci.c:695 in routine
> > ahci_enable_ahci() because HOST_AHCI_EN is not set.
> > 
> 
> This patch fixes boot failure on my AMD 64 laptop, can you please test
> this patch:
> 
> [PATCH] x86: fix _CRS resources return handling
> 
> We need to check for info->res_num and only handle for < PCI_BUS_NUM_RESOURCES
> 
> Also set info->bus->resource[info->res_num] for _CRS resources return handling
> 
> Fixed boot failure on some machine.
> 
> Reported-by: Larry Finger <Larry.Finger@...inger.net>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
> ---
>  arch/x86/pci/acpi.c |   16 ++++++++++------
>  1 files changed, 10 insertions(+), 6 deletions(-)

Ah, nice! I suspect it was this upstream commit causing it:

f9cde5f: x86/ACPI: Correct maximum allowed _CRS returned resources and warn if exceeded

right?

Jesse, you'll handle this, right? I'll apply it to tip:out-of-tree 
(not-for-upstream) for testing.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/