linux-kernel - Re: [PATCH] pata_rdc: driver for RDC ATA devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090624235548.681b8992@lxorguk.ukuu.org.uk>
Date:	Wed, 24 Jun 2009 23:55:48 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	linux-kernel@...r.kernel.org, kevin.huang@....com.tw,
	greg@...ah.com, Linux IDE mailing list <linux-ide@...r.kernel.org>
Subject: Re: [PATCH] pata_rdc: driver for RDC ATA devices

> Seems fine and fairly straightforward to me.  My lone comment -- go 
> through and replace magic numbers with named constants, for e.g. the PCI 
> config registers that program timings...

Its based on your ata_piix driver. Feel free to update that and I'll pull
names and things across to match.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/