linux-kernel - Re: [PATCH] pata_rdc: driver for RDC ATA devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1245886425.29098.117.camel@Joe-Laptop.home>
Date:	Wed, 24 Jun 2009 16:33:45 -0700
From:	Joe Perches <joe@...ches.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Jeff Garzik <jeff@...zik.org>, linux-kernel@...r.kernel.org,
	kevin.huang@....com.tw, greg@...ah.com,
	Linux IDE mailing list <linux-ide@...r.kernel.org>
Subject: Re: [PATCH] pata_rdc: driver for RDC ATA devices

On Wed, 2009-06-24 at 23:55 +0100, Alan Cox wrote:
> > Seems fine and fairly straightforward to me.  My lone comment -- go 
> > through and replace magic numbers with named constants, for e.g. the PCI 
> > config registers that program timings...
> 
> Its based on your ata_piix driver. Feel free to update that and I'll pull
> names and things across to match.

I sent a few patches to Jeff privately to do just that.

I'm waiting for Jeff to see if he wants me to post
them publicly or not.

btw:

Jeff, your email address in MAINTAINERS is jgarzik@...ox.com.
Should it be changed to redhat.com or garzik.org or left as is.

$ git log --since=1-year-ago | grep -i "by:.*garzik" | \
	cut -f2- -d":" | sort | uniq -c | sort -rn
    865  Jeff Garzik <jgarzik@...hat.com>
     13  Jeff Garzik <jgarzik@...ox.com>
     13  Jeff Garzik <jeff@...zik.org>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/