linux-kernel - Re: possible recursive locking detected at kmem_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0906261036080.21067@melkki.cs.Helsinki.FI>
Date:	Fri, 26 Jun 2009 10:37:25 +0300 (EEST)
From:	Pekka J Enberg <penberg@...helsinki.fi>
To:	"Pallipadi, Venkatesh" <venkatesh.pallipadi@...el.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"rjw@...k.pl" <rjw@...k.pl>, mingo@...e.hu,
	cl@...ux-foundation.org, npiggin@...e.de, a.p.zijlstra@...llo.nl
Subject: Re: possible recursive locking detected at kmem_cache_free

Hi Venki,

On Thu, 25 Jun 2009, Pallipadi, Venkatesh wrote:
> > > Not sure if this has been reported elsewhere. I started seeing this with git
> > > kernel from this morning on a system with RedHat EL5 base installation with
> > > ext3 root file system. Attached is the config I am using.
> > > 
> > > Let me know if you need any more details. This seems to be at every boot. I
> > > am trying the bisect right now.
> > > 
> > 
> > Thanks.  Let's cc Pekka.
> > 
> 
> git bisect result.

Thanks! I think I just broke lockdep annotations for slab. Does this patch 
fix things?

			Pekka

diff --git a/mm/slab.c b/mm/slab.c
index e74a16e..37ee532 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -1544,9 +1544,6 @@ void __init kmem_cache_init(void)
 	}
 
 	g_cpucache_up = EARLY;
-
-	/* Annotate slab for lockdep -- annotate the malloc caches */
-	init_lock_keys();
 }
 
 void __init kmem_cache_init_late(void)
@@ -1563,6 +1560,9 @@ void __init kmem_cache_init_late(void)
 	/* Done! */
 	g_cpucache_up = FULL;
 
+	/* Annotate slab for lockdep -- annotate the malloc caches */
+	init_lock_keys();
+
 	/*
 	 * Register a cpu startup notifier callback that initializes
 	 * cpu_cache_get for all new cpus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/