linux-kernel - Re: [PATCH RFC] fix RCU-callback-after-kmem_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1246005913.27533.21.camel@penberg-laptop>
Date:	Fri, 26 Jun 2009 11:45:13 +0300
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	paulmck@...ux.vnet.ibm.com
Cc:	Matt Mackall <mpm@...enic.com>, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, cl@...ux-foundation.org, jdb@...x.dk,
	Nick Piggin <npiggin@...e.de>
Subject: Re: [PATCH RFC] fix RCU-callback-after-kmem_cache_destroy problem
 in sl[aou]b

On Thu, 2009-06-25 at 15:08 -0700, Paul E. McKenney wrote:
> On Thu, Jun 25, 2009 at 04:27:19PM -0500, Matt Mackall wrote:
> > On Thu, 2009-06-25 at 12:31 -0700, Paul E. McKenney wrote:
> > > Hello!
> > > 
> > > Jesper noted that kmem_cache_destroy() invokes synchronize_rcu() rather
> > > than rcu_barrier() in the SLAB_DESTROY_BY_RCU case, which could result
> > > in RCU callbacks accessing a kmem_cache after it had been destroyed.
> > > 
> > > The following untested (might not even compile) patch proposes a fix.
> > 
> > Acked-by: Matt Mackall <mpm@...enic.com>
> > 
> > Nick, you'll want to make sure you get this in SLQB.
> > 
> > > Reported-by: Jesper Dangaard Brouer <jdb@...x.dk>
> 
> And I seem to have blown Jesper's email address (apologies, Jesper!), so:
> 
> Reported-by: Jesper Dangaard Brouer <hawk@...x.dk>

Compiles and boots here so I went ahead and applied the patch. ;) Thanks
a lot Paul!

			Pekka

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/