linux-kernel - Re: [PATCH 18/19] drivers/video: Use PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090626095454.GH9980@sci.fi>
Date:	Fri, 26 Jun 2009 12:54:54 +0300
From:	Ville Syrjälä <syrjala@....fi>
To:	Joe Perches <joe@...ches.com>
Cc:	linux-kernel@...r.kernel.org, Paul Mackerras <paulus@...ba.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Russell King <linux@....linux.org.uk>,
	Antonino Daplas <adaplas@...il.com>,
	Petr Vandrovec <vandrove@...cvut.cz>,
	Thomas Winischhofer <thomas@...ischhofer.net>,
	linux-fbdev-devel@...ts.sourceforge.net
Subject: Re: [PATCH 18/19] drivers/video: Use PCI_VDEVICE

On Wed, Jun 24, 2009 at 10:13:34PM -0700, Joe Perches wrote:
<snip>
> +	{ PCI_VDEVICE(ATI, PCI_DEVICE_ID_ATI_RAGE128_TS), rage_128_ultra },
> +	{ PCI_VDEVICE(ATI, PCI_DEVICE_ID_ATI_RAGE128_TT), rage_128_ultra },
> +	{ PCI_VDEVICE(ATI, PCI_DEVICE_ID_ATI_RAGE128_TU), rage_128_ultra },
>  	{ 0, }
>  };

Perhaps there should be a PCI_VDDEVICE() or something for this type of
stuff? Would make things even shorter.

Also PCI_VDEVICE() does not use named initializers for some reason.
Might be worth fixing.

It seems your script missed atyfb. It could use PCI_VDEVICE() too.

-- 
Ville Syrjälä
syrjala@....fi
http://www.sci.fi/~syrjala/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/