linux-kernel - Re: [PATCH 18/19] drivers/video: Use PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1246034126.18587.19.camel@Joe-Laptop.home>
Date:	Fri, 26 Jun 2009 09:35:26 -0700
From:	Joe Perches <joe@...ches.com>
To:	Ville Syrjälä <syrjala@....fi>
Cc:	linux-kernel@...r.kernel.org, Paul Mackerras <paulus@...ba.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Russell King <linux@....linux.org.uk>,
	Antonino Daplas <adaplas@...il.com>,
	Petr Vandrovec <vandrove@...cvut.cz>,
	Thomas Winischhofer <thomas@...ischhofer.net>,
	linux-fbdev-devel@...ts.sourceforge.net
Subject: Re: [PATCH 18/19] drivers/video: Use PCI_VDEVICE

On Fri, 2009-06-26 at 12:54 +0300, Ville Syrjälä wrote:
> Perhaps there should be a PCI_VDDEVICE() or something for this type of
> stuff? Would make things even shorter.

drivers/edac/edac_core.h has:

#define PCI_VEND_DEV(vend, dev) PCI_VENDOR_ID_ ## vend, \
	PCI_DEVICE_ID_ ## vend ## _ ## dev

Try submitting a patch and see what happens...

> Also PCI_VDEVICE() does not use named initializers for some reason.
> Might be worth fixing.

Perhaps that's to avoid mixing named and unnamed initializers.

> It seems your script missed atyfb. It could use PCI_VDEVICE() too.

Can you show an example please?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/