linux-kernel - Re: [PATCH 2/9] x86: introduce a set of platform feature flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090626191345.GA3061@elte.hu>
Date:	Fri, 26 Jun 2009 21:13:45 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	"H. Peter Anvin" <hpa@...ux.intel.com>
Cc:	"Pan, Jacob jun" <jacob.jun.pan@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 2/9] x86: introduce a set of platform feature flags


* H. Peter Anvin <hpa@...ux.intel.com> wrote:

> Ingo Molnar wrote:
> > 
> > Btw., this enumeration of basic PC features isnt bad in itself - and 
> > if there's a boot-flag based detection method (like on MRST) then 
> > this can convey a 'should this platform driver attempt to 
> > initialize' information to the driver, and rather cleanly so.
> > 
> 
> That is the whole point of this, yes. [...]

Except that about half of all the actual uses of platform_has() are 
all but related to the "should this driver initialize" question ;-)

They are more used as "fudge platform code a bit here and there to 
meet the limited constraints of the platform".

And that kind of fudging is a problem, obviously.

> [...] Furthermore, it is expected that we *also* would be able to 
> set platform flags based on early probes.

Yeah.

> > But there's bad uses of this as well, and those bad uses seem to 
> > dominate this patch-set.
> 
> Not entirely surprising, since this stuff is more or less randomly 
> sprinkled through the existing code.  We have a huge bunch of 
> legacy code and yes, it needs cleanup.
> 
> This is a huge opportunity, of course, but it's going to be a lot 
> of work.  A lot of this is likely to overlap directly with the 
> needs of Xen, too.

Correct.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/