linux-kernel - Re: [PATCH 8/9] x86/apic: match destination id with destination mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m1ws6yhdm2.fsf@fess.ebiederm.org>
Date:	Fri, 26 Jun 2009 14:47:01 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	"Pan\, Jacob jun" <jacob.jun.pan@...el.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Jeremy Fitzhardinge <jeremy@...p.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...ux.intel.com>
Subject: Re: [PATCH 8/9] x86/apic: match destination id with destination mode

"Pan, Jacob jun" <jacob.jun.pan@...el.com> writes:

> [[JPAN]] For Moorestown production silicon, we will use apic_default which uses
>  logical dest mode. This patch is not required.
> But, I think it is wrong to assign destination ID without looking at the mode 
> bit. If we have a new apic_xxxx with phy dest mode, we would have logical APIC 
> ID assigned to physical mode.

Both phys dest and logical dest use the same bits in the apic.
The code that assigns the destination knows which mode we are operating in.

Even not supporting logical mode is likely ok.  The key thing is doing the
work in the auto detect logic and not doing something weird in the assignments.

Eric


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/