linux-kernel - Re: [PATCHv2] Adding rumble support to Thrustmaster Dual Trigger 3-in-1 devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.0906290058370.18021@wotan.suse.de>
Date:	Mon, 29 Jun 2009 01:00:02 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	"rubenatch@...il.com" <rubenatch@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2] Adding rumble support to Thrustmaster Dual Trigger
 3-in-1 devices

On Fri, 26 Jun 2009, rubenatch@...il.com wrote:

> 
> From: Rubén Aós Garralda <rubenatch@...il.com>
> 
> This patch enables rumble in Thrustmaster Dual 3-in-1 trigger gamepads (in
> both PC and PS3 modes). It uses the same code as Thrustmaster FireStorm Dual
> Power 2/3, so it only modifies hid-core.c (to put the devices in the
> "forbidden list" and hid-tmff.c to add the new USB IDs.

Could you please also send your Signed-off-by: line, so that I can 
properly merge the patch?

> diff -uprN linux-source-2.6.30/drivers/hid/hid-core.c
> linux-source-test/drivers/hid/hid-core.c
> --- linux-source-2.6.30/drivers/hid/hid-core.c	2009-06-10 05:05:27.000000000
> +0200
> +++ linux-source-test/drivers/hid/hid-core.c	2009-06-26 15:33:48.000000000
> +0200
> @@ -1309,6 +1309,8 @@ static const struct hid_device_id hid_bl
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_SUNPLUS,
>  	USB_DEVICE_ID_SUNPLUS_WDESKTOP) },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb300) },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb304) },
> +	{ HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb323) },
> +       	{ HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb324) },

This is whitespace damaged.

Otherwise the patch is OK.

Thanks!

-- 
Jiri Kosina
SUSE Labs