linux-kernel - Re: kerneloops.org report for the week

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87iqifl8ao.fsf@basil.nowhere.org>
Date:	Mon, 29 Jun 2009 11:05:03 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Arjan van de Ven <arjan@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Yinghai Lu <yinghai@...nel.org>, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	netdev@...r.kernel.org, x86@...nel.org
Subject: Re: kerneloops.org report for the week

Ingo Molnar <mingo@...e.hu> writes:
>
>> Rank 8: generic_get_mtrr (warning)
>> 	Reported 544 times (2061 total reports)
>> 	BIOS bug where the MTRRs are not set up correctly
>> 	This warning was last seen in version 2.6.30, and first seen in 2.6.25.3.
>> 	More info: http://www.kerneloops.org/searchweek.php?search=generic_get_mtrr
>
> I think this calls for enabling the x86 MTRR sanitizer by default - 
> 500 out of 15000 reports suggests a significant proportion of Linux 
> systems is affected by MTRR setup problems.

The question is if the MTRRs are really wrong. The generic.c code checks
against the maximum address space reported by the CPU, but the BIOS might
only sets up the address space that is actually used. The later
is not really wrong; it's not needed to set MTRRs for non existing
mappings.

It might be better to double check against the max e820 mapping too
or drop that check.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/