linux-kernel - Re: [PATCH v2] enable x2APIC without interrupt remapping under KVM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 29 Jun 2009 03:46:56 -0700
From:	Suresh Siddha <suresh.b.siddha@...el.com>
To:	Gleb Natapov <gleb@...hat.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Sheng Yang <sheng@...ux.intel.com>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"avi@...hat.com" <avi@...hat.com>
Subject: Re: [PATCH v2] enable x2APIC without interrupt remapping under KVM

On Mon, 2009-06-29 at 03:08 -0700, Gleb Natapov wrote:
>  
> -	local_irq_save(flags);
>  	mask_IO_APIC_setup(ioapic_entries);
> -	mask_8259A();

Is there a reason why the 8259 mask/unmask operations are separated from
io-apic mask/unmask operations.

Can we keep it together so that it will be easy to read and understand
that we first do the interrupt subsystem mask, try enabling IR and
x2apic and  unmask the interrupt subsystem.

Otherwise I am ok with this change.

thanks,
suresh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/