linux-kernel - [patch] fix hugepage unuseable issu on non-NUMA machine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 29 Jun 2009 19:10:02 +0800
From:	"alex.shi" <alex.shi@...el.com>
To:	Yinghai@...nel.org
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Chen, Tim C" <tim.c.chen@...el.com>,
	"Zhang, Yanmin" <yanmin.zhang@...el.com>
Subject: [patch] fix hugepage unuseable issu on non-NUMA machine

73d60b7f747176dbdff826c4127d22e1fd3f9f74 commit introduced a nodes_clear
function for NUMA machine. But seems the commit omits non-NUMA machine.
If find_zone_movable_pfns_for_nodes/early_calculate_totalpages has no
chance to run. nodes_clear will block HUPEPAGE using in my specjbb2005
testing. 


So maybe we need to disable nodes_clear sometimes. With the following
patch. specjbb2005 recovered. 


Signed-off-by: Alex Shi <alex.shi@...el.com>
---
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 5d714f8..46ff861 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -4246,7 +4246,8 @@ void __init free_area_init_nodes(unsigned long *max_zone_pfn)
 	 * find_zone_movable_pfns_for_nodes/early_calculate_totalpages init
 	 * that node_mask, clear it at first
 	 */
-	nodes_clear(node_states[N_HIGH_MEMORY]);
+	if (required_kernelcore)
+		nodes_clear(node_states[N_HIGH_MEMORY]);
 	/* Initialise every node */
 	mminit_verify_pageflags_layout();
 	setup_nr_node_ids();




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/