linux-kernel - Re: + memory-hotplug-update-zone-pcp-at-memory-online.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.1.10.0906301020420.6124@gentwo.org>
Date:	Tue, 30 Jun 2009 10:21:34 -0400 (EDT)
From:	Christoph Lameter <cl@...ux-foundation.org>
To:	Shaohua Li <shaohua.li@...el.com>
cc:	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	"mel@....ul.ie" <mel@....ul.ie>,
	"Zhao, Yakui" <yakui.zhao@...el.com>
Subject: Re: + memory-hotplug-update-zone-pcp-at-memory-online.patch added
 to -mm tree

On Tue, 30 Jun 2009, Shaohua Li wrote:

> > foreach possible cpu?
> Just follows zone_pcp_init(), do you think we should change that too?

I plan to change that but for now this would be okay.

> > > +		struct per_cpu_pageset *pset;
> > > +		struct per_cpu_pages *pcp;
> > > +
> > > +		pset = zone_pcp(zone, cpu);
> > > +		pcp = &pset->pcp;
> > > +
> > > +		local_irq_save(flags);
> > > +		free_pages_bulk(zone, pcp->count, &pcp->list, 0);
> >
> > There are no pages in the pageset since the pcp batch is zero right?
> It might not be zero for a populated zone, see above comments.

But you are populating an unpopulated zone?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/