linux-kernel - Re: [PATCH v1 3/6][ARM] new ARM SoC support: BCMRing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090630211249.GA10001@n2100.arm.linux.org.uk>
Date:	Tue, 30 Jun 2009 22:12:49 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Trilok Soni <soni.trilok@...il.com>
Cc:	"Leo (Hao) Chen" <leochen@...adcom.com>,
	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>,
	"linux-arm-kernel@...ts.arm.linux.org.uk" 
	<linux-arm-kernel@...ts.arm.linux.org.uk>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 3/6][ARM] new ARM SoC support: BCMRing

On Tue, Jun 30, 2009 at 11:00:41AM +0530, Trilok Soni wrote:
> Hi Leo,
> 
> > I'll fix the errors found by the checkpatch.pl script.  Is it okay to pass the checkpatch.pl with some warnings?
> >
> 
> I don't think so, but if you find any false positives you can report to ML.

The answer is actually yes.  For instance, if you have a prink where
the string you're printing goes over the 80 column limit, you have two
choices:

1. wrap the string.  This is considered bad practice since it means
   that you can't grep the kernel source for the exact message.

2. leave the string as is and ignore the checkpatch warning.

(2) is considered better practice than (1).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/