linux-kernel - [PATCH 4/8] SELinux netlabel.c non trivial fixes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1246512767-2999-5-git-send-email-justinmattock@gmail.com>
Date:	Wed,  1 Jul 2009 22:32:43 -0700
From:	"Justin P. Mattock" <justinmattock@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	selinux@...ho.nsa.gov,
	"Justin P. Mattock" <justinmattock@...il.com>
Subject: [PATCH 4/8] SELinux netlabel.c non trivial fixes.

Signed-off-by: Justin P. Mattock <justinmattock@...il.com>

Fix a comment to sound better.
Fix some comments.
---
 security/selinux/netlabel.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/security/selinux/netlabel.c b/security/selinux/netlabel.c
index 2e98441..7868ea2 100644
--- a/security/selinux/netlabel.c
+++ b/security/selinux/netlabel.c
@@ -167,7 +167,7 @@ void selinux_netlbl_sk_security_reset(struct sk_security_struct *ssec)
  *
  * Description:
  * Call the NetLabel mechanism to get the security attributes of the given
- * packet and use those attributes to determine the correct context/SID to
+ * packet and use those attributes to determine the correct context/SID to be
  * assign to the packet.  Returns zero on success, negative values on failure.
  *
  */
@@ -216,8 +216,8 @@ int selinux_netlbl_skbuff_setsid(struct sk_buff *skb,
 	struct netlbl_lsm_secattr *secattr = NULL;
 	struct sock *sk;
 
-	/* if this is a locally generated packet check to see if it is already
-	 * being labeled by it's parent socket, if it is just exit */
+	/* If this is a locally generated packet check to see if it is already
+	 * being labeled by it's parent socket, if it is just exit. */
 	sk = skb->sk;
 	if (sk != NULL) {
 		struct sk_security_struct *sksec = sk->sk_security;
@@ -444,9 +444,9 @@ int selinux_netlbl_socket_connect(struct sock *sk, struct sockaddr *addr)
 	local_bh_disable();
 	bh_lock_sock_nested(sk);
 
-	/* connected sockets are allowed to disconnect when the address family
+	/* Connected sockets are allowed to disconnect when the address family
 	 * is set to AF_UNSPEC, if that is what is happening we want to reset
-	 * the socket */
+	 * the socket. */
 	if (addr->sa_family == AF_UNSPEC) {
 		netlbl_sock_delattr(sk);
 		sksec->nlbl_state = NLBL_REQSKB;
-- 
1.6.3.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/