[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1246512767-2999-6-git-send-email-justinmattock@gmail.com>
Date: Wed, 1 Jul 2009 22:32:44 -0700
From: "Justin P. Mattock" <justinmattock@...il.com>
To: linux-kernel@...r.kernel.org
Cc: selinux@...ho.nsa.gov,
"Justin P. Mattock" <justinmattock@...il.com>
Subject: [PATCH 5/8] SELinux netnode.c non trivial fixes.
Signed-off-by: Justin P. Mattock <justinmattock@...il.com>
Fix some comments.
---
security/selinux/netnode.c | 20 ++++++++++----------
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/security/selinux/netnode.c b/security/selinux/netnode.c
index 7100072..426c41d 100644
--- a/security/selinux/netnode.c
+++ b/security/selinux/netnode.c
@@ -57,11 +57,11 @@ struct sel_netnode {
struct rcu_head rcu;
};
-/* NOTE: we are using a combined hash table for both IPv4 and IPv6, the reason
+/* NOTE: We are using a combined hash table for both IPv4 and IPv6, the reason
* for this is that I suspect most users will not make heavy use of both
* address families at the same time so one table will usually end up wasted,
* if this becomes a problem we can always add a hash table for each address
- * family later */
+ * family later. */
static LIST_HEAD(sel_netnode_list);
static DEFINE_SPINLOCK(sel_netnode_lock);
@@ -94,8 +94,8 @@ static void sel_netnode_free(struct rcu_head *p)
*/
static unsigned int sel_netnode_hashfn_ipv4(__be32 addr)
{
- /* at some point we should determine if the mismatch in byte order
- * affects the hash function dramatically */
+ /* At some point we should determine if the mismatch in byte order
+ * affects the hash function dramatically. */
return (addr & (SEL_NETNODE_HASH_SIZE - 1));
}
@@ -110,9 +110,9 @@ static unsigned int sel_netnode_hashfn_ipv4(__be32 addr)
*/
static unsigned int sel_netnode_hashfn_ipv6(const struct in6_addr *addr)
{
- /* just hash the least significant 32 bits to keep things fast (they
+ /* Just hash the least significant 32 bits to keep things fast (they
* are the most likely to be different anyway), we can revisit this
- * later if needed */
+ * later if needed. */
return (addr->s6_addr32[3] & (SEL_NETNODE_HASH_SIZE - 1));
}
@@ -184,8 +184,8 @@ static void sel_netnode_insert(struct sel_netnode *node)
INIT_RCU_HEAD(&node->rcu);
- /* we need to impose a limit on the growth of the hash table so check
- * this bucket to make sure it is within the specified bounds */
+ /* We need to impose a limit on the growth of the hash table so check
+ * this bucket to make sure it is within the specified bounds. */
list_add_rcu(&node->list, &sel_netnode_hash[idx].list);
if (sel_netnode_hash[idx].size == SEL_NETNODE_HASH_BKT_LIMIT) {
struct sel_netnode *tail;
@@ -252,8 +252,8 @@ out:
spin_unlock_bh(&sel_netnode_lock);
if (unlikely(ret)) {
printk(KERN_WARNING
- "SELinux: failure in sel_netnode_sid_slow(),"
- " unable to determine network node label\n");
+ "SELinux: Failure in sel_netnode_sid_slow(),"
+ " unable to determine network node label.\n");
kfree(new);
}
return ret;
--
1.6.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists