linux-kernel - Re: [PATCH] vt: add an event interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090703164225.GA21447@elte.hu>
Date:	Fri, 3 Jul 2009 18:42:25 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] vt: add an event interface


* Alan Cox <alan@...rguk.ukuu.org.uk> wrote:

> A good example of what happens if you don't is
> 
> scripts/checkpatch.pl --file arch/x86/kernel/cpu/mtrr/*c
> 
> where the core part of the code isn't changed very much even 
> though the interfaces completely get reworked. Thus it never gets 
> cleaned up and reviewed as a whole. The code works, will probably 
> work for years but never gets looked at as a whole and tidied.

I think even the MTRR code (which is indeed one of the few x86 
places still not fully cleaned up) supports my arguments.

Look at the averages:

                                      errors   lines of code   errors/KLOC
arch/x86/kernel/cpu/mtrr/amd.c             2             120          16.6
arch/x86/kernel/cpu/mtrr/centaur.c         8             225          35.5
arch/x86/kernel/cpu/mtrr/cleanup.c         0            1102             0
arch/x86/kernel/cpu/mtrr/cyrix.c          10             275          36.3
arch/x86/kernel/cpu/mtrr/generic.c        16             730          21.9
arch/x86/kernel/cpu/mtrr/if.c             11             428          25.7
arch/x86/kernel/cpu/mtrr/main.c           50             751          66.5
arch/x86/kernel/cpu/mtrr/state.c           0              83             0

The arch/x86/kernel/cpu/mtrr/cleanup.c file is a new bit and 
relatively clean.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/