linux-kernel - Re: [PATCH] SElinux: Fix some typos.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A4D7C94.2020307@gmail.com>
Date:	Thu, 02 Jul 2009 20:35:48 -0700
From:	"Justin P. Mattock" <justinmattock@...il.com>
To:	James Morris <jmorris@...ei.org>
CC:	linux-kernel@...r.kernel.org, selinux@...ho.nsa.gov
Subject: Re: [PATCH] SElinux: Fix some typos.

James Morris wrote:
> On Thu, 2 Jul 2009, Justin P. Mattock wrote:
>
>    
>> Signed-off-by: Justin P. Mattock<justinmattock@...il.com>
>>
>> Fix some typos in some comments.
>>      
>
>    
>> -/* The file system's label must be initialized prior to use. */
>> +/* The filesystems label must be initialized prior to use. */
>>      
>
> Your adding grammertical error's.
>
>    
well, after figuring out how to have git send -email functioning correctly,
I needed something to send.      : ^ )
(but after doing a quick google filesystem did show up).
>> -	 * Note that the setting of hard limits (even to lower them) can be
>> +	 * Note: That the setting of hard limits (even to lower them) can be
>>      
>
> Please get this patch reviewed by an English speaker.
>
>    
That seems viable to me.
>>    * Description:
>>    * Call the NetLabel mechanism to get the security attributes of the given
>> - * packet and use those attributes to determine the correct context/SID to
>> - * assign to the packet.  Returns zero on success, negative values on failure.
>> + * packet and use those attributes to determine the correct context/SID to be
>> + * assigned to the packet.  Returns zero on success, negative values on failure.
>>      
>
> Eschew the active voice?
>
>
> - James
>    
wast ist das?
No I will not be afraid of submitting patches, and having them be rejected.
all part of the learning curve.

Justin P. Mattock
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/