linux-kernel - Re: [tip:perfcounters/urgent] x86: atomic64: Move the 32-bit atomic64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090705112545.GA1062@elte.hu>
Date:	Sun, 5 Jul 2009 13:25:45 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Paul Mackerras <paulus@...ba.org>
Cc:	mingo@...hat.com, hpa@...or.com, acme@...hat.com,
	linux-kernel@...r.kernel.org, eric.dumazet@...il.com,
	torvalds@...ux-foundation.org, a.p.zijlstra@...llo.nl,
	efault@....de, arnd@...db.de, fweisbec@...il.com,
	dhowells@...hat.com, akpm@...ux-foundation.org, tglx@...utronix.de,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:perfcounters/urgent] x86: atomic64: Move the 32-bit
	atomic64_t implementation to a .c file


* Paul Mackerras <paulus@...ba.org> wrote:

> tip-bot for Ingo Molnar writes:
> 
> > Also, while at it, rename all uses of 'unsigned long long' to
> > the much shorter u64.
> > 
> > This makes the appearance of the prototypes a lot nicer - and
> > it also uncovered a few bugs where (yet unused) API variants
> > had 'long' as their return type instead of u64.
> 
> Did you consider making atomic64_t a signed type on 32-bit x86 
> like it is on all 64-bit platforms, and like atomic_t is 
> everywhere?

That did not occur to me and it makes sense - this would clean up a 
few explicit s64 casts we do there currently.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/