linux-kernel - Re: [GIT PULL] [PATCH 0/22] trivial fixes typo "foo foo"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 7 Jul 2009 09:11:48 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	David Howells <dhowells@...hat.com>
Cc:	Jaswinder Singh Rajput <jaswinder@...nel.org>, dhowells@...hat.com,
	trivial <trivial@...nel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	David Miller <davem@...emloft.net>,
	Russell King <rmk+lkml@....linux.org.uk>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Tony Luck <tony.luck@...el.com>, benh@...nel.crashing.org,
	Alan Cox <alan@...rguk.ukuu.org.uk>, mchehab@...radead.org,
	James Bottomley <James.Bottomley@...senPartnership.com>,
	Greg Ungerer <gerg@...pgear.com>, Greg KH <greg@...ah.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Andreas Herrmann <andreas.herrmann3@....com>,
	Ingo Molnar <mingo@...e.hu>, tytso@....edu, sct@...hat.com,
	Gadiyar Anand <gadiyar@...com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] [PATCH 0/22] trivial fixes typo "foo foo"

On Tue, 07 Jul 2009 16:44:00 +0100
David Howells <dhowells@...hat.com> wrote:

> Jaswinder Singh Rajput <jaswinder@...nel.org> wrote:
> 
> > Jaswinder Singh Rajput (22):
> >       trivial: fix typo "has has" in multiple files
> >       trivial: fix typo "on on" in multiple files
> >       trivial: fix typo "that that" in multiple files
> 
> NAK.  You can't just mechanically reduce the above pairs of words to
> a single instance unconditionally.
> 
> "has has" should perhaps be "has had" in some cases.
> 
> In "on on", the first preposition may be part of a compound verb (eg:
> "to go on").
> 
> In "that that", the second "that" may be specifying the object in
> relation to a previous part of the text.

What's more, these types of patchsets don't actually improve things in
any real way.  If these changes were submitted as part of some greater
work, involving clarifying the text or making the text match the code,
or cleaning up the code in some real way (refactoring common stuff etc)
I'd be fine with it.

But as it stands it just makes lkml that much more difficult to read,
and clogs the changelog with fairly useless bits.  But maybe I'm
missing the "greater work" part of this set; I haven't looked at all 22
patches here.

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/