linux-kernel - Re: [PATCH 16/22] trivial: fix typo "that that" in multiple files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 7 Jul 2009 09:30:53 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
Cc:	trivial <trivial@...nel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 16/22] trivial: fix typo "that that" in multiple files

On Tue, Jul 07, 2009 at 07:52:31PM +0530, Jaswinder Singh Rajput wrote:
> 
> Replaced "that that" with "that" in multiple files
> 
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
> ---
>  Documentation/RCU/rcu.txt                |    2 +-
>  Documentation/block/as-iosched.txt       |    2 +-
>  Documentation/kernel-parameters.txt      |    2 +-
>  Documentation/memory-barriers.txt        |    2 +-
>  Documentation/networking/ipvs-sysctl.txt |    2 +-
>  Documentation/trace/ftrace.txt           |    2 +-
>  arch/ia64/hp/sim/simeth.c                |    2 +-
>  arch/m68k/kernel/head.S                  |    4 ++--
>  arch/powerpc/kernel/ftrace.c             |    4 ++--
>  arch/s390/lib/delay.c                    |    2 +-
>  block/cfq-iosched.c                      |    2 +-
>  crypto/twofish_common.c                  |    2 +-
>  drivers/char/rio/riointr.c               |    2 +-
>  drivers/input/serio/hp_sdc.c             |    2 +-
>  drivers/net/bonding/bond_alb.c           |    2 +-
>  drivers/s390/char/tape_34xx.c            |    2 +-
>  drivers/usb/wusbcore/wa-xfer.c           |    2 +-
>  fs/configfs/dir.c                        |    2 +-
>  fs/direct-io.c                           |    2 +-
>  fs/jbd/checkpoint.c                      |    2 +-
>  fs/jbd2/checkpoint.c                     |    2 +-
>  fs/ntfs/layout.h                         |    2 +-
>  fs/xfs/xfs_trans.c                       |    2 +-
>  include/linux/ieee80211.h                |    2 +-
>  24 files changed, 26 insertions(+), 26 deletions(-)
> 
> diff --git a/Documentation/RCU/rcu.txt b/Documentation/RCU/rcu.txt
> index 7aa2002..1f3f992 100644
> --- a/Documentation/RCU/rcu.txt
> +++ b/Documentation/RCU/rcu.txt
> @@ -30,7 +30,7 @@ o	How can the updater tell when a grace period has completed
>  	Just as with spinlocks, RCU readers are not permitted to
>  	block, switch to user-mode execution, or enter the idle loop.
>  	Therefore, as soon as a CPU is seen passing through any of these
> -	three states, we know that that CPU has exited any previous RCU
> +	three states, we know that CPU has exited any previous RCU
>  	read-side critical sections.  So, if we remove an item from a
>  	linked list, and then wait until all CPUs have switched context,
>  	executed in user mode, or executed in the idle loop, we can

As David Howells noted, this is not correct.  To fix the admittedly
awkward phrasing, how about the following?

	Just as with spinlocks, RCU readers are not permitted to block,
	switch to user-mode execution, or enter the idle loop.	Therefore,
	as soon as a given CPU is seen passing through any of these
	three states, we know that this CPU has exited any previous RCU
	read-side critical sections.  So, if we remove an item from a
	linked list, and then wait until all CPUs have switched context,
	executed in user mode, or executed in the idle loop, we can

							Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/