linux-kernel - Re: [PATCH] kmemcheck: fix sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1247081981.18386.10.camel@johannes.local>
Date:	Wed, 08 Jul 2009 21:39:41 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Vegard Nossum <vegard.nossum@...il.com>
Cc:	Pekka J Enberg <penberg@...helsinki.fi>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-sparse@...r.kernel.org
Subject: Re: [PATCH] kmemcheck: fix sparse warning

On Wed, 2009-07-08 at 21:28 +0200, Vegard Nossum wrote:

> >  #define kmemcheck_annotate_bitfield(ptr, name)                         \
> > -       do if (ptr) {                                                   \
> > +       do { if (ptr) {                                                 \
> >                int _n = (long) &((ptr)->name##_end)                    \
> >                        - (long) &((ptr)->name##_begin);                \
> >                BUILD_BUG_ON(_n < 0);                                   \
> >                                                                        \
> >                kmemcheck_mark_initialized(&((ptr)->name##_begin), _n); \
> > -       } while (0)
> > +       } } while (0)
> >
> >  #define kmemcheck_annotate_variable(var)                               \
> >        do {                                                            \
> >
> >
> >
> 
> I'll change the patch title to "kmemcheck: work around bogus sparse
> warning" and fix the indentation, sounds ok?

Well, it's debatable whether it's bogus or not, but I don't care as long
as it gets fixed.

> Meanwhile, I Cced sparse mailing list in case somebody else knows
> anything else about this warning (what it means, whether it's
> justified in this case, whether it should be fixed in sparse, etc.).

Everybody take me off the CC please then :) This has been discussed far
too many times already. In this special case, the warning probably isn't
all that useful, but ISTR Linus saying that he wanted it this way.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)