linux-kernel - [PATCH] cpufreq: Unbreak build for !SMP: symlinked cpus cannot happen for !SMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200907091043.39607.trenn@suse.de>
Date:	Thu, 9 Jul 2009 10:43:35 +0200
From:	Thomas Renninger <trenn@...e.de>
To:	Daniel Mack <daniel@...aq.de>
Cc:	linux-kernel@...r.kernel.org,
	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>,
	Venkatesh Pallipadi <venkatesh.pallipadi@...el.com>,
	rjw@...k.pl, mingo@...e.hu, Shaohua Li <shaohua.li@...el.com>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Dave Young <hidave.darkstar@...il.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	sven.wegener@...aler.net, cpufreq@...r.kernel.org,
	Dave Jones <davej@...hat.com>
Subject: [PATCH] cpufreq: Unbreak build for !SMP: symlinked cpus cannot happen for !SMP

Or like that:
Either all #ifdef CONFIG_SMP related conditionals to managed cpus
should vanish or all should be covered. This one takes the latter
approach.

---
'managed_policy' is used for the non-smp case in line 941.

Make the symlink code conditional to #ifdef CONFIG_SMP as already
done at other places.

Signed-off-by: Thomas Renninger <trenn@...e.de>

Index: cpufreq/drivers/cpufreq/cpufreq.c
===================================================================
--- cpufreq.orig/drivers/cpufreq/cpufreq.c
+++ cpufreq/drivers/cpufreq/cpufreq.c
@@ -930,6 +930,7 @@ static int cpufreq_add_dev(struct sys_de
 	}
 	spin_unlock_irqrestore(&cpufreq_driver_lock, flags);
 
+#ifdef CONFIG_SMP
 	/* symlink affected CPUs */
 	for_each_cpu(j, policy->cpus) {
 		if (j == cpu)
@@ -947,6 +948,7 @@ static int cpufreq_add_dev(struct sys_de
 			goto err_out_unregister;
 		}
 	}
+#endif
 
 	policy->governor = NULL; /* to assure that the starting sequence is
 				  * run in cpufreq_set_policy */

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/