linux-kernel - Re: [PATCH] rework/fix is_single

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28464.1247144463@redhat.com>
Date:	Thu, 09 Jul 2009 14:01:03 +0100
From:	David Howells <dhowells@...hat.com>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	dhowells@...hat.com, Andrew Morton <akpm@...ux-foundation.org>,
	jmorris@...ei.org, roland@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rework/fix is_single_threaded()

Oleg Nesterov <oleg@...hat.com> wrote:

> Unless David replies.

Sorry, I missed the last three messages.

> David, do you still dislike ->mmap_sem? I didn't see other objections,
> and again, imho tasklist_lock is worse.

My main objection to taking mmap_sem is that it restricts where the function
can be used.  It can't, for example, be called by anyone holding a spinlock.
Furthermore, the more locks, the more chance of someone accidentally
deadlocking something.

But apart from that, go for it.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/