linux-kernel - Re: [PATCH] move w100fb's probe function to .devinit.text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A59117B.6020309@f2s.com>
Date:	Sat, 11 Jul 2009 23:26:03 +0100
From:	Ian molton <spyro@....com>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
CC:	Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	Philipp Zabel <philipp.zabel@...il.com>,
	Richard Purdie <rpurdie@...ys.net>,
	Antonino Daplas <adaplas@...il.com>,
	Alberto Mardegan <mardy@...rs.sourceforge.net>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] move w100fb's probe function to .devinit.text


Acked-by: Ian Molton <ian@...menth.co.uk>

Uwe Kleine-König wrote:
> A pointer to w100fb_probe is passed to the core via
> platform_driver_register and so the function must not disappear when the
> .init sections are discarded.  Otherwise (if also having HOTPLUG=y)
> unbinding and binding a device to the driver via sysfs will result in an
> oops as does a device being registered late.
> 
> An alternative to this patch is using platform_driver_probe instead of
> platform_driver_register plus removing the pointer to the probe function
> from the struct platform_driver.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Cc: Philipp Zabel <philipp.zabel@...il.com>
> Cc: Ian Molton <spyro@....com>
> Cc: Richard Purdie <rpurdie@...ys.net>
> Cc: Antonino Daplas <adaplas@...il.com>
> Cc: Alberto Mardegan <mardy@...rs.sourceforge.net>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> ---
>  drivers/video/w100fb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/w100fb.c b/drivers/video/w100fb.c
> index 2376f68..5d22395 100644
> --- a/drivers/video/w100fb.c
> +++ b/drivers/video/w100fb.c
> @@ -628,7 +628,7 @@ static int w100fb_resume(struct platform_device *dev)
>  #endif
>  
>  
> -int __init w100fb_probe(struct platform_device *pdev)
> +int __devinit w100fb_probe(struct platform_device *pdev)
>  {
>  	int err = -EIO;
>  	struct w100fb_mach_info *inf;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/