linux-kernel - Re: possible regression with pty.c commit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090711232452.4dc7c1ba@lxorguk.ukuu.org.uk>
Date:	Sat, 11 Jul 2009 23:24:52 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Sergey Senozhatsky <sergey.senozhatsky@...l.by>
Cc:	Alan Cox <alan@...ux.intel.com>, Alan Cox <alan@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: possible regression with pty.c commit

On Sat, 11 Jul 2009 22:15:56 +0300
Sergey Senozhatsky <sergey.senozhatsky@...l.by> wrote:

> Hello,
> commit d945cb9cce20ac7143c2de8d88b187f62db99bdc ("pty: Rework the pty layer to use the normal buffering logic")
> seems to brake kdesu.

This looks like a timing bug in kdesu at first glance but it may be more
complex.

> close(11)                               = 0

We close one side of the pty/tty pair

> write(10, "stop", 4)                    = 4
> write(10, "\n", 1)                      = 1
> fcntl64(10, F_GETFL)                    = 0x2 (flags O_RDWR)
> read(10, 0xbf840858, 255)               = -1 EIO (Input/output error)		<<<<<<<<<

At this point the other side is closed, we have a hangup and the read
correctly I think gets -EIO.

I will have a look at kdesu on Monday, I've got Fedora setups here so
hopefully I can reproduce it simply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/