linux-kernel - Re: possible regression with pty.c commit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090711235530.GA3231@localdomain.by>
Date:	Sun, 12 Jul 2009 02:55:30 +0300
From:	Sergey Senozhatsky <sergey.senozhatsky@...l.by>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: possible regression with pty.c commit

On (07/11/09 23:24), Alan Cox wrote:
> On Sat, 11 Jul 2009 22:15:56 +0300
> Sergey Senozhatsky <sergey.senozhatsky@...l.by> wrote:
> 
> > Hello,
> > commit d945cb9cce20ac7143c2de8d88b187f62db99bdc ("pty: Rework the pty layer to use the normal buffering logic")
> > seems to brake kdesu.
> 
> This looks like a timing bug in kdesu at first glance but it may be more
> complex.
> 
> > close(11)                               = 0
> 
> We close one side of the pty/tty pair
> 
> > write(10, "stop", 4)                    = 4
> > write(10, "\n", 1)                      = 1
> > fcntl64(10, F_GETFL)                    = 0x2 (flags O_RDWR)
> > read(10, 0xbf840858, 255)               = -1 EIO (Input/output error)		<<<<<<<<<
> 
> At this point the other side is closed, we have a hangup and the read
> correctly I think gets -EIO.
> 
> I will have a look at kdesu on Monday, I've got Fedora setups here so
> hopefully I can reproduce it simply.
> 

Alan, I forgot to tell - I'm using KDE 3.5.9 (3.5.10). Don't know whether this can be reproduced with KDE 4.x.x.

	Sergey
Download attachment "signature.asc" of type "application/pgp-signature" (316 bytes)