linux-kernel - Re: [PATCH] move omap_udc's probe function to .devinit.text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200907121512.18358.david-b@pacbell.net>
Date:	Sun, 12 Jul 2009 15:12:18 -0700
From:	David Brownell <david-b@...bell.net>
To:	"Uwe Kleine-König" 
	<u.kleine-koenig@...gutronix.de>
Cc:	Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	Philipp Zabel <philipp.zabel@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Tony Lindgren <tony@...mide.com>,
	Russell King <rmk@....linux.org.uk>,
	Dmitry Baryshkov <dbaryshkov@...il.com>
Subject: Re: [PATCH] move omap_udc's probe function to .devinit.text

On Sunday 12 July 2009, Uwe Kleine-König wrote:
> On Sat, Jul 11, 2009 at 03:30:44PM -0700, David Brownell wrote:
> > Repeat -- NAK on this.  Use platform_driver_probe() instead.
>
> Oh, I just noticed that this patch is a relict.  The driver was changed
> to use platform_driver_probe in
> 864e28b4f24106b799e991fa136fa6fa2b638a68.

Good.
 

> And I just found another similar problem.
> E.g. clevo_mail_led_probe is defined to live in .init.text and uses
> platform_driver_probe, but as it's referenced in the driver struct my
> script matched this file.
> 
> (Is it wrong (wrong as in "worth to be fixed") to reference the probe
> function in the driver struct when platform_driver_probe is used?

Wrong, but not dangerous ... so fix, but at low priority.
At least, low until the DEBUG_SECTION_MISMATCH stuff gets
re-enabled.

When platform_driver_probe() returns, that driver field willl
have changed to something safe.


> If so 
> at least
> 
> 	drivers/serial/msm_serial.c
> 	drivers/i2c/busses/i2c-imx.c
> 
> are effected, too.  Patches at
> 
> 	http://news.gmane.org/find-root.php?group=gmane.linux.ports.arm.kernel&article=62319
> 
> )
> 
> The other patches are not affected.
> 
> @Greg:  Please just drop these two patches:
> 
> 	[PATCH] move omap_udc's probe function to .devinit.text
> 	[PATCH] move leds-clevo-mail's probe function to .devinit.text

... and the others I NAKed too.


> 
> Sorry for the unconvenience.
> 
> Best regards
> Uwe
> 
> -- 
> Pengutronix e.K.                              | Uwe Kleine-König            |
> Industrial Linux Solutions                    | http://www.pengutronix.de/  |
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/