linux-kernel - Re: [PATCH] move omap_udc's probe function to .devinit.text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200907121521.31188.david-b@pacbell.net>
Date:	Sun, 12 Jul 2009 15:21:30 -0700
From:	David Brownell <david-b@...bell.net>
To:	Russell King <rmk+lkml@....linux.org.uk>
Cc:	"Uwe Kleine-König" 
	<u.kleine-koenig@...gutronix.de>, Greg KH <gregkh@...e.de>,
	linux-kernel@...r.kernel.org,
	Philipp Zabel <philipp.zabel@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Tony Lindgren <tony@...mide.com>,
	Dmitry Baryshkov <dbaryshkov@...il.com>
Subject: Re: [PATCH] move omap_udc's probe function to .devinit.text

On Sunday 12 July 2009, Russell King wrote:
> 	 David's approach is an enhancement whereas your patches
> are a bug fix.

Not an enhancement.  Uwe's current approach causes regressions
in terms of kernel runtime footprint.  That is, pages will newly
be made to sit around doing *nothing* forever, when they could
have been used to get Real Work done.  And, pre-patches, they
would have been getting Real Work done.

If it weren't a regression I wouldn't have objected.

A few years back, I measured the impact of having probe() and
friends in a section -- init{,data} vs devinit{,data} -- that gets
removed.  Most drivers were in the 1K-2K range.  $SUBJECT was
larger than most, but there were some with even more discardable
init logic.

All that adds up.  There's no point to commiting patches that
do things wrong *and* waste space, then need to fix things up
again later when it's easy to do it right in the first place.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/