linux-kernel - Re: Input driver for Twinhan USB 6253:0100 remote control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.0907131048110.10476@wotan.suse.de>
Date:	Mon, 13 Jul 2009 10:53:13 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Bruno Prémont <bonbons@...ux-vserver.org>
Cc:	Mark Lord <lkml@....ca>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: Input driver for Twinhan USB 6253:0100 remote control

On Sun, 12 Jul 2009, Bruno Prémont wrote:

> I wrote the below patch to adjust it's key mappings, though I'm not
> sure if/how I should deal with the number keys (0..9) with regard to
> keyboard layout and/or numlock key.
> 
> I tried with KEY_0..KEY_9 (default) as well as KEY_KP0..KEY_KP9 but
> neither produces optimal results on my machine (laptop with numlock
> disabled and belgian keyboard layout, e.g. KEY_1 => '&' unless shift
> is down)
> 
> KEY_NUMERIC_0..KEY_NUMERIC_9 are not recognized by Linux console (don't
> know if/how userspace understands them)

Are they incorporated in the keymap you have loaded?

> +	// set_bit(EV_REP, hi->input->evbit);

Why is this commented out?

Otherwise the patch looks good, so if you send it with proper 
Signed-off-by line, I am OK with merging it.

Do you have any idea whether lirc folks have plans to integrate support 
for this device to lirc eventually?

Thanks,

-- 
Jiri Kosina
SUSE Labs