linux-kernel - Re: [PATCH 1/2] fs/xfs: Drop unnecessary NULL test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bzy7hybzh6k.fsf@fransum.emea.sgi.com>
Date:	Tue, 14 Jul 2009 12:34:43 +0200
From:	Olaf Weber <olaf@....com>
To:	Julia Lawall <julia@...u.dk>
Cc:	felixb@....com, xfs-masters@....sgi.com, xfs@....sgi.com,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/2] fs/xfs: Drop unnecessary NULL test

Julia Lawall writes:

> From: Julia Lawall <julia@...u.dk>
> The result of container_of should not be NULL.  In particular, in this case
> the argument to the enclosing function has passed though INIT_DELAYED_WORK,
> which dereferences it, implying that its container cannot be NULL.

Given the defn of container_of() it seems clear that neither its input
pointer nor its result should ever be NULL.

In this particular case, there is a check for NULL and early exit in
xfs_mru_cache_create(), the function that does the INIT_DELAYED_WORK().

Olaf

> The semantic match that finds this problem is as follows:
> (http://www.emn.fr/x-info/coccinelle/)

> // <smpl>
> @@
> expression x,e;
> @@
> x = container_of(...)
> ... when != x = e
> * x == NULL
> // </smpl>

> Signed-off-by: Julia Lawall <julia@...u.dk>

Acked-By: Olaf Weber <olaf@....com>

> ---
>  fs/xfs/xfs_mru_cache.c              |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

> diff --git a/fs/xfs/xfs_mru_cache.c b/fs/xfs/xfs_mru_cache.c
> index 4b0613d..0651ce7 100644
> --- a/fs/xfs/xfs_mru_cache.c
> +++ b/fs/xfs/xfs_mru_cache.c
> @@ -280,8 +280,8 @@ _xfs_mru_cache_reap(
>  	xfs_mru_cache_t		*mru = container_of(work, xfs_mru_cache_t, work.work);
>  	unsigned long		now, next;
 
> -	ASSERT(mru && mru->lists);
> -	if (!mru || !mru->lists)
> +	ASSERT(mru->lists);
> +	if (!mru->lists)
>  		return;
 
>  	spin_lock(&mru->lock);

-- 
Olaf Weber                 SGI               Phone:  +31(0)30-6696752
                           Veldzigt 2b       Fax:    +31(0)30-6696799
Technical Lead             3454 PW de Meern  Vnet:   955-7151
Storage Software           The Netherlands   Email:  olaf@....com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/