linux-kernel - Re: HTC: touchscreen driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090714221638.GA6512@elf.ucw.cz>
Date:	Wed, 15 Jul 2009 00:16:39 +0200
From:	Pavel Machek <pavel@....cz>
To:	Arve Hj?nnev?g <arve@...roid.com>
Cc:	Brian Swetland <swetland@...gle.com>,
	kernel list <linux-kernel@...r.kernel.org>
Subject: Re: HTC: touchscreen driver

Hi!

> >> >        if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
> >> >                printk(KERN_ERR "synaptics_ts_probe: need I2C_FUNC_I2C\n");
> >> > @@ -269,6 +354,9 @@ static int synaptics_ts_probe(
> >> >        pdata = client->dev.platform_data;
> >> >        if (pdata)
> >> >                ts->power = pdata->power;
> >> > +       else
> >> > +               pdata = kzalloc(sizeof(*pdata), GFP_KERNEL);
> >> > +
> >>
> >> Where do you free this?
> >
> > Well, nowhere; but it should not actually matter. ... btw can this
> > path (!pdata) actually trigger? The driver will not be working,
> > anyway, in that case..
> 
> The driver should work fine without the pdata. The pdata is used to
> align the touchscreen data with the screen behind it.

Ok...

> >> This driver only supports a subset of Synaptics' devices so a more
> >> generic driver will eventually be needed. The patch below adds support
> >> for a more recent but similar panel.
> >
> > Ok, that should be simple enough to apply, but lets do improvements
> > when we cleaned the code enough for the mainline...?
> 
> We need this change now. Your cleanup will cause conflicts for anyone
> using our driver, so it would be better if it includes all our fixes.

Well, I don't expect you to use the cleaned-up driver as-is: I had to
remove the wakelocks functionality as infrastructure is not in
mainline. (Plus, I do not have hardware to test your latest version).

Applying small patch on top of cleaned up driver should be better than
carrying whole driver itself, right?

[Alternatively... I can try to incorporate your change, but I'd need
your testing at that point.]
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/