| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <d6200be20907141545k2b40b790x1af853b89517891c@mail.gmail.com> Date: Tue, 14 Jul 2009 15:45:45 -0700 From: Arve Hjønnevåg <arve@...roid.com> To: Pavel Machek <pavel@....cz> Cc: Brian Swetland <swetland@...gle.com>, kernel list <linux-kernel@...r.kernel.org> Subject: Re: HTC: touchscreen driver On Tue, Jul 14, 2009 at 3:16 PM, Pavel Machek<pavel@....cz> wrote: ... >> >> This driver only supports a subset of Synaptics' devices so a more >> >> generic driver will eventually be needed. The patch below adds support >> >> for a more recent but similar panel. >> > >> > Ok, that should be simple enough to apply, but lets do improvements >> > when we cleaned the code enough for the mainline...? >> >> We need this change now. Your cleanup will cause conflicts for anyone >> using our driver, so it would be better if it includes all our fixes. > > Well, I don't expect you to use the cleaned-up driver as-is: I had to > remove the wakelocks functionality as infrastructure is not in > mainline. OK. The driver does not use wakelocks tough, only earlysuspend, so your cleaned up version should be fully functional. The early suspend hooks are only used to save power in idle when the screen is off. > (Plus, I do not have hardware to test your latest version). True, but the protocol documentation is available: http://www.synaptics.com/sites/default/files/511_000099_01F.pdf > > Applying small patch on top of cleaned up driver should be better than > carrying whole driver itself, right? Perhaps, but the only problem I encountered with this driver so far was when calling disable_irq from the interrupt handler stopped working on non-smp systems in 2.6.30 (which is another patch you should probably apply first). > > [Alternatively... I can try to incorporate your change, but I'd need > your testing at that point.] > Pavel > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html > -- Arve Hjønnevåg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists