linux-kernel - Re: [PATCH 18/20] ceph: debugging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090717185641.GH8046@one.firstfloor.org>
Date:	Fri, 17 Jul 2009 20:56:41 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Sage Weil <sage@...dream.net>
Cc:	Andi Kleen <andi@...stfloor.org>, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 18/20] ceph: debugging

Good.

Sorry for not doing more (and more serious) reviews, not enough
time right now.

> #define _dout(fmt, args...)						\
> 	pr_debug(" %12.12s:%-4d : " fmt "%s",				\
> 		 ceph_file_part(__FILE__, sizeof(__FILE__)),		\
> 		 __LINE__, args);

That seems like a wasteful way to do this -- i bet you could
shrink binary size with debugging on considerably if you move
the file_part into a function.

-Andi


-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/