[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0907171247570.23194@cobra.newdream.net>
Date: Fri, 17 Jul 2009 12:52:33 -0700 (PDT)
From: Sage Weil <sage@...dream.net>
To: Andi Kleen <andi@...stfloor.org>
cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 18/20] ceph: debugging
On Fri, 17 Jul 2009, Andi Kleen wrote:
> Good.
>
> Sorry for not doing more (and more serious) reviews, not enough
> time right now.
You've been helpful nonetheless, thanks! :)
> > #define _dout(fmt, args...) \
> > pr_debug(" %12.12s:%-4d : " fmt "%s", \
> > ceph_file_part(__FILE__, sizeof(__FILE__)), \
> > __LINE__, args);
>
> That seems like a wasteful way to do this -- i bet you could
> shrink binary size with debugging on considerably if you move
> the file_part into a function.
If you mean ceph_file_part shouldn't be inline, definitely. Beyond that
I'm not sure what more to change... it's just a few extra chars on the
format string and 2 calls instead of 1?
sage
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists