linux-kernel - Re: "floppy: fix hibernation" causes error on resume from ram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200907182019.57909.linux@rainbow-software.org>
Date:	Sat, 18 Jul 2009 20:19:54 +0200
From:	Ondrej Zary <linux@...nbow-software.org>
To:	Alan Jenkins <alan-jenkins@...fmail.co.uk>
Cc:	Ingo Molnar <mingo@...e.hu>, Pavel Machek <pavel@....cz>,
	Jens Axboe <jens.axboe@...cle.com>,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	Kernel Testers List <kernel-testers@...r.kernel.org>
Subject: Re: "floppy: fix hibernation" causes error on resume from ram

On Saturday 18 July 2009 20:06:54 Alan Jenkins wrote:
> Thanks for the hibernation fix!  Until recently I thought my floppy was
> just dead.  Unfortunately, the fix seems to cause me errors on resume
> from suspend to ram.  The floppy works fine afterwards, it just spams
> the log.
>
> On 2.6.30 there were no errors, and the floppy survived suspend-to-ram.
> So I guess the quick fix would be to only do the fix-up on resume from
> hibernation, and not suspend-to-ram.

My machine has no suspend-to-RAM so I haven't tested it.

That would be probably the correct fix. But how to do it? AFAIK, there's only 
one suspend() and one resume() for everything. And that looks very wrong as 
resume-from-hibernation is fundamentally different from resume-from-RAM.

>
> Thanks
> Alan
>
> Jul 18 15:27:23 alan-desktop kernel: [34795.256645]
> Jul 18 15:27:23 alan-desktop kernel: [34795.256647] floppy driver state
> Jul 18 15:27:23 alan-desktop kernel: [34795.256649] -------------------
> Jul 18 15:27:23 alan-desktop kernel: [34795.256652] now=4305315874 last
> interrupt=4303125175 diff=2190699 last called handler=ffffffffa00a64d0
> Jul 18 15:27:23 alan-desktop kernel: [34795.256655] timeout_message=lock
> fdc Jul 18 15:27:23 alan-desktop kernel: [34795.256657] last output bytes:
> Jul 18 15:27:23 alan-desktop kernel: [34795.256659]  8 80 4295201276 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256662]  8 80 4295201276 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256664]  8 80 4295201276 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256666]  8 80 4295201276 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256668]  8 80 4297332499 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256669]  8 80 4297332499 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256671]  8 80 4297332499 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256673]  8 80 4297332499 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256675]  8 80 4298652310 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256677]  8 80 4298652310 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256679]  8 80 4298652310 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256681]  8 80 4298652310 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256683]  8 80 4299614961 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256685]  8 80 4299614961 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256687]  8 80 4299614961 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256689]  8 80 4299614961 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256691]  8 80 4303125175 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256693]  8 80 4303125175 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256695]  8 80 4303125175 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256697]  8 80 4303125175 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256699] last result at 4303125175
> Jul 18 15:27:23 alan-desktop kernel: [34795.256701] last redo_fd_request
> at 4303125175
> Jul 18 15:27:23 alan-desktop kernel: [34795.256703]
> Jul 18 15:27:23 alan-desktop kernel: [34795.256709] status=0
> Jul 18 15:27:23 alan-desktop kernel: [34795.256711] fdc_busy=1
> Jul 18 15:27:23 alan-desktop kernel: [34795.256713]
> do_floppy=ffffffffa00a64d0
> Jul 18 15:27:23 alan-desktop kernel: [34795.256715] cont=ffffffffa00ad8c0
> Jul 18 15:27:23 alan-desktop kernel: [34795.256717] current_req=(null)
> Jul 18 15:27:23 alan-desktop kernel: [34795.256719] command_status=-1
> Jul 18 15:27:23 alan-desktop kernel: [34795.256720]
> Jul 18 15:27:23 alan-desktop kernel: [34795.256829] floppy0: floppy
> timeout called
> Jul 18 15:27:23 alan-desktop kernel: [34795.259455] Restarting tasks ...
> done.



-- 
Ondrej Zary
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/