linux-kernel - Re: "floppy: fix hibernation" causes error on resume from ram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4A621416.2060609@tuffmail.co.uk>
Date:	Sat, 18 Jul 2009 19:27:34 +0100
From:	Alan Jenkins <alan-jenkins@...fmail.co.uk>
To:	Ondrej Zary <linux@...nbow-software.org>
CC:	Ingo Molnar <mingo@...e.hu>, Pavel Machek <pavel@....cz>,
	Jens Axboe <jens.axboe@...cle.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Kernel Testers List <kernel-testers@...r.kernel.org>
Subject: Re: "floppy: fix hibernation" causes error on resume from ram

Ondrej Zary wrote:
> On Saturday 18 July 2009 20:06:54 Alan Jenkins wrote:
>   
>> Thanks for the hibernation fix!  Until recently I thought my floppy was
>> just dead.  Unfortunately, the fix seems to cause me errors on resume
>> from suspend to ram.  The floppy works fine afterwards, it just spams
>> the log.
>>
>> On 2.6.30 there were no errors, and the floppy survived suspend-to-ram.
>> So I guess the quick fix would be to only do the fix-up on resume from
>> hibernation, and not suspend-to-ram.
>>     
>
> My machine has no suspend-to-RAM so I haven't tested it.
>
> That would be probably the correct fix. But how to do it? AFAIK, there's only 
> one suspend() and one resume() for everything. And that looks very wrong as 
> resume-from-hibernation is fundamentally different from resume-from-RAM.
>   

Ok.  Looking at drivers/base/platform.c, we want "restore()".  I guess I
can do the patch myself :-).

Thanks
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/